Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit version name to 30 characters, AS-339 #933

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Limit version name to 30 characters, AS-339 #933

merged 3 commits into from
Nov 27, 2024

Conversation

AltamashShaikh
Copy link
Contributor

@AltamashShaikh AltamashShaikh commented Nov 26, 2024 •
edited
Loading

Description:

Limit version name to 30 characters
Fixes: AS-339

Review

@AltamashShaikh AltamashShaikh changed the title Fixes possible xss via version name, AS-339 Limit version name to 30 characters, AS-339 Nov 26, 2024
snake14
snake14 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I confirmed that the API now validates the input for max length and that the HTML is no longer executed in the Publish help text showing the previous version name 👍

@AltamashShaikh AltamashShaikh merged commit 7f0c799 into 5.x-dev Nov 27, 2024
5 checks passed
@AltamashShaikh AltamashShaikh deleted the AS-339-fix-xss branch November 27, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snake14 snake14 snake14 approved these changes

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AltamashShaikh @snake14